Add peer dependencies between packages #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-peer-dependencies
branch
2 times, most recently
from
ce1fd3d to
ad5a6f8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Gudahtt
force-pushed
the
add-peer-dependencies
branch
from
ad5a6f8 to
0e20a86
Compare
Gudahtt
changed the title
Packages now list `peerDependencies` to represent the expectation that a specific package version is setup with the controller messenger. This ensures that projects using these packages get a warning upon install if they are using incompatible package versions. This lets us safely make breaking changes to controller messenger events and actions. The constraints needed adjustment to allow the same dependency to be declared both in `dependencies` and `peerDependencies`. The constraint now ensures packages aren't listed both in `dependencies` and `devDependencies` instead.
Gudahtt
force-pushed
the
add-peer-dependencies
branch
from
0e20a86 to
88b9611
Compare
mcmire
approved these changes
Dec 5, 2022
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
Packages now list `peerDependencies` to represent the expectation that a
specific package version is setup with the controller messenger. This
ensures that projects using these packages get a warning upon install if
they are using incompatible package versions.
This lets us safely make breaking changes to controller messenger events
and actions.
The constraints needed adjustment to allow the same dependency to be
declared both in `dependencies` and `peerDependencies`. The constraint
now ensures packages aren't listed both in `dependencies` and
`devDependencies` instead.
- FIXED:
- The following packages now warn if a required package is not present:
- `assets-controllers`
- `gas-fee-controller`
- `permission-controller`
**Checklist**
- [x] Tests are included if applicable
- [x] Any added code is fully documented
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Packages now list `peerDependencies` to represent the expectation that a
specific package version is setup with the controller messenger. This
ensures that projects using these packages get a warning upon install if
they are using incompatible package versions.
This lets us safely make breaking changes to controller messenger events
and actions.
The constraints needed adjustment to allow the same dependency to be
declared both in `dependencies` and `peerDependencies`. The constraint
now ensures packages aren't listed both in `dependencies` and
`devDependencies` instead.
- FIXED:
- The following packages now warn if a required package is not present:
- `assets-controllers`
- `gas-fee-controller`
- `permission-controller`
**Checklist**
- [x] Tests are included if applicable
- [x] Any added code is fully documented
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Packages now list `peerDependencies` to represent the expectation that a
specific package version is setup with the controller messenger. This
ensures that projects using these packages get a warning upon install if
they are using incompatible package versions.
This lets us safely make breaking changes to controller messenger events
and actions.
The constraints needed adjustment to allow the same dependency to be
declared both in `dependencies` and `peerDependencies`. The constraint
now ensures packages aren't listed both in `dependencies` and
`devDependencies` instead.
- FIXED:
- The following packages now warn if a required package is not present:
- `assets-controllers`
- `gas-fee-controller`
- `permission-controller`
**Checklist**
- [x] Tests are included if applicable
- [x] Any added code is fully documented
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages now list
peerDependenciesto represent the expectation that a specific package version is setup with the controller messenger. This ensures that projects using these packages get a warning upon install if they are using incompatible package versions.This lets us safely make breaking changes to controller messenger events and actions.
The constraints needed adjustment to allow the same dependency to be declared both in
dependenciesandpeerDependencies. The constraint now ensures packages aren't listed both independenciesanddevDependenciesinstead.FIXED:
assets-controllersgas-fee-controllerpermission-controllerChecklist