Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Yarn 3 #847

Closed
Gudahtt opened this issue Jun 6, 2022 · 0 comments · Fixed by #846
Closed

Migrate to Yarn 3 #847

Gudahtt opened this issue Jun 6, 2022 · 0 comments · Fixed by #846
Assignees
Labels
enhancement New feature or request

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Jun 6, 2022

We want to migrate from Yarn v1 to Yarn v3. The main reason for migrating is that Yarn v3 is better maintained. Yarn v1 is not being maintained anymore, and includes various bugs that will never be fixed. We're also hoping that certain Yarn v3 will be useful when this repository is converted into a monorepo.

@Gudahtt Gudahtt self-assigned this Jun 6, 2022
@Gudahtt Gudahtt added the enhancement New feature or request label Jun 6, 2022
Gudahtt added a commit that referenced this issue Jun 6, 2022
The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide [1] have been followed. Effectively
everything should work the same way it did before.

Closes #847

[1]: https://yarnpkg.com/getting-started/migration
Gudahtt added a commit that referenced this issue Jun 7, 2022
The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide [1] have been followed. Effectively
everything should work the same way it did before.

Closes #847

[1]: https://yarnpkg.com/getting-started/migration
Gudahtt added a commit that referenced this issue Jun 23, 2022
The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide [1] have been followed. Effectively
everything should work the same way it did before.

Closes #847

[1]: https://yarnpkg.com/getting-started/migration
Gudahtt added a commit that referenced this issue Jun 24, 2022
* Migrate from Yarn v1 to Yarn v3

The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide [1] have been followed. Effectively
everything should work the same way it did before.

Closes #847

[1]: https://yarnpkg.com/getting-started/migration

* Replace `setup` script with new Yarn plugin

The old `setup` script has been replaced with a Yarn v3 plugin that
will automatically run `allow-scripts` after install. We can now use
`yarn install` again as normal.

This was done to address a problem that happened when running
`yarn setup` for the first time. If Yarn 3 wasn't installed already, it
would throw an error. Yarn 3 doesn't automatically install itself until
you run the `install` command directly.

The `setup` script has been left behind for now so that it still works
if people run it accidentally. We can remove it later once we've become
accustomed to this new workflow.

* Fix typo

Co-authored-by: Elliot Winkler <[email protected]>

* Skip linting `.yarnrc.yml`

This file gets auto-generated by Yarn, so there is no need for us to
lint it.

* Replace plugin with "official" version

The plugin has been reinstalled from the LavaMoat repository. Comments
have also been removed from the `.yarnrc.yml` file.

Co-authored-by: Elliot Winkler <[email protected]>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
* Migrate from Yarn v1 to Yarn v3

The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide [1] have been followed. Effectively
everything should work the same way it did before.

Closes #847

[1]: https://yarnpkg.com/getting-started/migration

* Replace `setup` script with new Yarn plugin

The old `setup` script has been replaced with a Yarn v3 plugin that
will automatically run `allow-scripts` after install. We can now use
`yarn install` again as normal.

This was done to address a problem that happened when running
`yarn setup` for the first time. If Yarn 3 wasn't installed already, it
would throw an error. Yarn 3 doesn't automatically install itself until
you run the `install` command directly.

The `setup` script has been left behind for now so that it still works
if people run it accidentally. We can remove it later once we've become
accustomed to this new workflow.

* Fix typo

Co-authored-by: Elliot Winkler <[email protected]>

* Skip linting `.yarnrc.yml`

This file gets auto-generated by Yarn, so there is no need for us to
lint it.

* Replace plugin with "official" version

The plugin has been reinstalled from the LavaMoat repository. Comments
have also been removed from the `.yarnrc.yml` file.

Co-authored-by: Elliot Winkler <[email protected]>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
* Migrate from Yarn v1 to Yarn v3

The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide [1] have been followed. Effectively
everything should work the same way it did before.

Closes #847

[1]: https://yarnpkg.com/getting-started/migration

* Replace `setup` script with new Yarn plugin

The old `setup` script has been replaced with a Yarn v3 plugin that
will automatically run `allow-scripts` after install. We can now use
`yarn install` again as normal.

This was done to address a problem that happened when running
`yarn setup` for the first time. If Yarn 3 wasn't installed already, it
would throw an error. Yarn 3 doesn't automatically install itself until
you run the `install` command directly.

The `setup` script has been left behind for now so that it still works
if people run it accidentally. We can remove it later once we've become
accustomed to this new workflow.

* Fix typo

Co-authored-by: Elliot Winkler <[email protected]>

* Skip linting `.yarnrc.yml`

This file gets auto-generated by Yarn, so there is no need for us to
lint it.

* Replace plugin with "official" version

The plugin has been reinstalled from the LavaMoat repository. Comments
have also been removed from the `.yarnrc.yml` file.

Co-authored-by: Elliot Winkler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant