-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TypeScript v5.1 #4370
Comments
@kanthesha Will you take this one to see what the potential issues might be so we can do refinement on it? |
For the trial run, branch from this PR where the v5.0 upgrade is in place: #3645. If the PR is merged, use the latest version of core. |
I went through what's new in 5.1. And most of the 5.1 improvements are automatically applied (developer experience and optimisation related changes, ). Particularly from 5.1, we can incorporate this new feature Easier Implicit Returns for undefined. I see that we are also talking about the changes in the earlier versions like |
@kanthesha should this be in "needs dev review"? Or "ready for dev"? |
We can move to "ready to Dev". |
Should we move this to Blocked since it's dependent on first bumping to TypeScript 5.0? |
## References - Closes #4370 ## Changelog ```md ### Changed - Upgrade TypeScript version to `~5.1.6` ([#4576](#4576)) ``` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.1, with the goal of eventually upgrading to the latest version.
Prior to starting the upgrade process, we should read through the v5.1 release announcements and make note of the following in this ticket:
satisfies
operator in v4.9).We should also do a trial run of bumping TypeScript versions in core packages and seeing what (if any) error messages we get when we run
yarn build
andyarn test
. These errors should be recorded in this ticket.The text was updated successfully, but these errors were encountered: