Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully migrate json-rpc-middleware-stream into core monorepo #1552

Closed
xinnanyemm opened this issue Jul 25, 2023 · 3 comments
Closed

Fully migrate json-rpc-middleware-stream into core monorepo #1552

xinnanyemm opened this issue Jul 25, 2023 · 3 comments
Assignees
@MajorLift @kanthesha
Labels
enhancement New feature or request Epic team-wallet-framework

Comments

@xinnanyemm
Copy link

xinnanyemm commented Jul 25, 2023 •
edited by mcmire
Loading

We would like to migrate the json-rpc-middleware-stream library into this repo to make it easier to maintain.

See the following checklist for instructions on accomplishing this: #1551 (comment)
@cryptodev-2s cryptodev-2s self-assigned this Sep 14, 2023
@Gudahtt
Copy link
Member

Gudahtt commented Sep 14, 2023 •
edited
Loading

At a glance, it looks like the repository updates needed prior to migrating it are:

  • Update Yarn from v1 to v3
  • Update TypeScript to v4.6.3

@xinnanyemm
Copy link
Author

Michele, Desi, and Kanthesha will discuss and break down into smaller PRs.

@kanthesha kanthesha self-assigned this Sep 15, 2023
@kanthesha
Copy link
Contributor

Are we looking for any specific version of Yarn 3? By default it is 3.6.3.

@mcmire mcmire changed the title Migrate json-rpc-middleware-stream libraries into core monorepo Migrate json-rpc-middleware-stream library into core monorepo Oct 20, 2023
@mcmire mcmire changed the title Migrate json-rpc-middleware-stream library into core monorepo Fully migrate json-rpc-middleware-stream into core monorepo Oct 20, 2023
@MajorLift MajorLift self-assigned this Nov 2, 2023
@MajorLift MajorLift mentioned this issue Nov 8, 2023
Merged
3 tasks
MajorLift added a commit that referenced this issue Nov 8, 2023
@MajorLift
Add json-rpc-middleware-stream to root tsconfig files (#2013)
c8cc547 
## Explanation

- Fixes missing `json-rpc-middleware-stream` entries in root tsconfig
files that causes build failure during release workflow.

- Will add note in migration process guide
(#1551 (comment))
about the importance of step C-2.

## References

- See #1552

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MajorLift MajorLift

@kanthesha kanthesha

Labels
enhancement New feature or request Epic team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Gudahtt @MajorLift @mikesposito @kanthesha @cryptodev-2s @xinnanyemm