Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyringController: addNewAccount should not change selected account #1244

Closed
mikesposito opened this issue Apr 21, 2023 · 0 comments · Fixed by #1296
Closed

KeyringController: addNewAccount should not change selected account #1244

mikesposito opened this issue Apr 21, 2023 · 0 comments · Fixed by #1296

Comments

@mikesposito
Copy link
Member

mikesposito commented Apr 21, 2023

This is part of the effort to consolidate keyring interactions between extension and mobile.
Originally proposed here.

Context

In the mobile client, the core KeyringController is patched to not switch accounts after creating a new one.

Solution

We should remove the account switch from the core KeyringController implementation, leaving this responsibility to clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants