Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyrings consolidation: Select account after calling addNewAccount #18759

Closed
mikesposito opened this issue Apr 24, 2023 · 0 comments · Fixed by #19814
Closed

Keyrings consolidation: Select account after calling addNewAccount #18759

mikesposito opened this issue Apr 24, 2023 · 0 comments · Fixed by #19814
Assignees
@mikesposito
Labels
release-10.36.0 Issue or pull request that will be included in release 10.36.0 snap-keyring-epic team-accounts team-wallet-framework

Comments

@mikesposito
Copy link
Member

mikesposito commented Apr 24, 2023 •
edited
Loading

This is part of the effort to consolidate keyring interactions between extension and mobile.
Originally proposed here.

After closing #1244, KeyringController's addNewAccount method will not switch account automatically anymore. This should then be done "manually" by clients, Extension included.
@mikesposito mikesposito changed the title Change selected account Select account after its creation Apr 24, 2023
@mikesposito mikesposito changed the title Select account after its creation Keyrings consolidation: Select account after its creation Apr 24, 2023
@mikesposito mikesposito changed the title Keyrings consolidation: Select account after its creation Keyrings consolidation: Select account after calling addNewAccount Apr 24, 2023
@mikesposito mikesposito mentioned this issue Jun 29, 2023
Merged
8 tasks
@mikesposito mikesposito self-assigned this Jun 29, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
release-10.36.0 Issue or pull request that will be included in release 10.36.0 snap-keyring-epic team-accounts team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use addNewAccount from core KeyringController MetaMask/metamask-extension
3 participants
@mikesposito @metamaskbot @xinnanyemm