addNewAccount doesn't select new account (#1296)

feat: addNewAccount doesn't select new account
MetaMask · Oct 11, 2023 · dbc8cc4 · dbc8cc4
1 parent e3af4c0
commit dbc8cc4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/packages/keyring-controller/src/KeyringController.test.ts b/packages/keyring-controller/src/KeyringController.test.ts
@@ -110,6 +110,7 @@ describe('KeyringController', () => {
           currentKeyringMemState.keyrings[0].accounts,
         ),
       ).toBe(true);
+      expect(preferences.setSelectedAddress.called).toBe(false);
     });
   });
 

diff --git a/packages/keyring-controller/src/KeyringController.ts b/packages/keyring-controller/src/KeyringController.ts
@@ -226,7 +226,6 @@ export class KeyringController extends BaseController<
     const addedAccountAddress = newAccounts.find(
       (selectedAddress: string) => !oldAccounts.includes(selectedAddress),
     );
-    this.setSelectedAddress(addedAccountAddress);
     return {
       keyringState: await this.fullUpdate(),
       addedAccountAddress,