Skip to content

Commit

Permalink
Migrate KeyringController to BaseControllerV2 (#1378)
Browse files Browse the repository at this point in the history
* feat: supp cacheEncryptionKey and submitEncryptionKey method

* docs: update jsdoc

* refactor: migrate KeyringController to BaseControllerV2

* fix: use immer v9

* rollback: controller parameters change

* refactor: change KeyringConfig to KeyringControllerConfig

* refactor: sync controller state with keyring state

* refactor: no vault sync

* refactor: use state value for isUnlocked

* refactor: use controller state for test assertions

* refactor: remove onLock and onUnlock in favor of events

* refactor: sync mem and persistent store

* refactor: apply review feedback

* refactor: use option bag for constructor

* fix: set immer as prod dependency

* fix: add encryption key and salt to memstore

* refactor: remove vault encryptionKey and encryptionSalt from returns

* fix: remove forgotten state return
  • Loading branch information
mikesposito authored and MajorLift committed Oct 11, 2023
1 parent 48a6233 commit b3318d8
Show file tree
Hide file tree
Showing 4 changed files with 310 additions and 287 deletions.
3 changes: 2 additions & 1 deletion packages/keyring-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"@metamask/preferences-controller": "workspace:^",
"async-mutex": "^0.2.6",
"ethereumjs-util": "^7.0.10",
"ethereumjs-wallet": "^1.0.1"
"ethereumjs-wallet": "^1.0.1",
"immer": "^9.0.6"
},
"devDependencies": {
"@ethereumjs/common": "^2.6.1",
Expand Down
Loading

0 comments on commit b3318d8

Please sign in to comment.