fix: init uses a timeout and other methods reattempt init
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
commented
Jan 17, 2025
Comment on lines
+322
to
+328
| this.iframe.onerror = (): void => { | ||
| if (this.iframe) { | ||
| document.head.removeChild(this.iframe); | ||
| } | ||
| this.iframeLoaded = false; | ||
| reject(new Error('Failed to load iframe')); | ||
| }; |
There was a problem hiding this comment.
I'm not sure that this is actually needed, since the timeout would kick in anyway, but seemed useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LedgerBridgeIframeclass gets initialized through theinitmethod. However, if the iframe that is set up during this method call fails for some reason, the promise returned byinitwill never resolve/reject.Downstream, this prevents the KeyringController mutex from being ever released, causing deadlocks at unlock time.
The solution applied in this PR is to make the iframe set up during the
initcall optional, and then later reattempting it whenever another method needs the iframe and finds it uninitialized