refactor: move deps to devDeps for types + use peerDep for keyring-api

MetaMask · Jan 20, 2025 · 2ad133a · 2ad133a
1 parent 325e597
commit 2ad133a
Show file tree

Hide file tree

Showing 11 changed files with 32 additions and 38 deletions.
diff --git a/.depcheckrc.yml b/.depcheckrc.yml
@@ -9,8 +9,6 @@ ignores:
   - 'tsd'
   # Ignore dependencies imported implicitly by TypeScript
   - '@types/*'
-  # Ignore peer dependencies that appears unused, but are required
-  - 'webextension-polyfill'
   # Ignore tools (packages which we use as executables and not libraries)
   - 'rimraf'
   - '@lavamoat/allow-scripts'

diff --git a/README.md b/README.md
@@ -46,17 +46,16 @@ linkStyle default opacity:0.5
   keyring_snap_sdk(["@metamask/keyring-snap-sdk"]);
   keyring_utils(["@metamask/keyring-utils"]);
   keyring_api --> keyring_utils;
-  keyring_internal_api --> keyring_api;
   keyring_internal_api --> keyring_utils;
-  keyring_internal_snap_client --> keyring_api;
+  keyring_internal_api --> keyring_api;
   keyring_internal_snap_client --> keyring_snap_client;
   keyring_internal_snap_client --> keyring_utils;
+  keyring_internal_snap_client --> keyring_api;
   eth_snap_keyring --> keyring_api;
-  eth_snap_keyring --> keyring_internal_api;
   eth_snap_keyring --> keyring_internal_snap_client;
   eth_snap_keyring --> keyring_utils;
-  keyring_snap_client --> keyring_api;
   keyring_snap_client --> keyring_utils;
+  keyring_snap_client --> keyring_api;
   keyring_snap_sdk --> keyring_utils;
   keyring_snap_sdk --> keyring_api;
 ```

diff --git a/packages/keyring-api/package.json b/packages/keyring-api/package.json
@@ -59,7 +59,6 @@
     "@ts-bridge/cli": "^0.6.1",
     "@types/jest": "^29.5.12",
     "@types/node": "^20.12.12",
-    "@types/webextension-polyfill": "^0.12.1",
     "deepmerge": "^4.2.2",
     "depcheck": "^1.4.7",
     "jest": "^29.5.0",

diff --git a/packages/keyring-eth-hd/package.json b/packages/keyring-eth-hd/package.json
@@ -61,7 +61,8 @@
     "@ts-bridge/cli": "^0.6.1",
     "@types/jest": "^29.5.12",
     "deepmerge": "^4.2.2",
-    "jest": "^29.5.0"
+    "jest": "^29.5.0",
+    "typescript": "~5.6.3"
   },
   "engines": {
     "node": "^18.18 || >=20"

diff --git a/packages/keyring-eth-trezor/package.json b/packages/keyring-eth-trezor/package.json
@@ -52,8 +52,7 @@
     "@metamask/eth-sig-util": "^8.1.2",
     "@trezor/connect-plugin-ethereum": "^9.0.3",
     "@trezor/connect-web": "^9.1.11",
-    "hdkey": "^2.1.0",
-    "tslib": "^2.6.2"
+    "hdkey": "^2.1.0"
   },
   "devDependencies": {
     "@ethereumjs/common": "^3.2.0",
@@ -76,9 +75,13 @@
     "sinon": "^19.0.2",
     "ts-jest": "^29.0.5",
     "ts-node": "^10.9.2",
+    "tslib": "^2.6.2",
     "typedoc": "^0.25.13",
     "typescript": "~5.6.3"
   },
+  "peerDependencies": {
+    "tslib": "^2.6.2"
+  },
   "engines": {
     "node": "^18.18 || >=20"
   },

diff --git a/packages/keyring-internal-api/package.json b/packages/keyring-internal-api/package.json
@@ -45,7 +45,6 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@metamask/keyring-api": "workspace:^",
     "@metamask/keyring-utils": "workspace:^",
     "@metamask/superstruct": "^3.1.0",
     "@metamask/utils": "^11.0.1"
@@ -54,6 +53,7 @@
     "@lavamoat/allow-scripts": "^3.2.1",
     "@lavamoat/preinstall-always-fail": "^2.1.0",
     "@metamask/auto-changelog": "^3.4.4",
+    "@metamask/keyring-api": "workspace:^",
     "@ts-bridge/cli": "^0.6.1",
     "@types/jest": "^29.5.12",
     "@types/node": "^20.12.12",
@@ -68,6 +68,9 @@
     "typedoc": "^0.25.13",
     "typescript": "~5.6.3"
   },
+  "peerDependencies": {
+    "@metamask/keyring-api": "workspace:^"
+  },
   "engines": {
     "node": "^18.18 || >=20"
   },

diff --git a/packages/keyring-internal-snap-client/package.json b/packages/keyring-internal-snap-client/package.json
@@ -45,7 +45,6 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@metamask/keyring-api": "workspace:^",
     "@metamask/keyring-snap-client": "workspace:^",
     "@metamask/keyring-utils": "workspace:^",
     "@metamask/snaps-controllers": "^9.10.0",
@@ -57,6 +56,7 @@
     "@lavamoat/allow-scripts": "^3.2.1",
     "@lavamoat/preinstall-always-fail": "^2.1.0",
     "@metamask/auto-changelog": "^3.4.4",
+    "@metamask/keyring-api": "workspace:^",
     "@metamask/providers": "^18.3.1",
     "@metamask/utils": "^11.0.1",
     "@ts-bridge/cli": "^0.6.1",

diff --git a/packages/keyring-snap-bridge/package.json b/packages/keyring-snap-bridge/package.json
@@ -40,26 +40,21 @@
     "@ethereumjs/tx": "^4.2.0",
     "@metamask/eth-sig-util": "^8.1.2",
     "@metamask/keyring-api": "workspace:^",
-    "@metamask/keyring-internal-api": "workspace:^",
     "@metamask/keyring-internal-snap-client": "workspace:^",
     "@metamask/keyring-utils": "workspace:^",
     "@metamask/snaps-controllers": "^9.10.0",
     "@metamask/snaps-sdk": "^6.7.0",
     "@metamask/snaps-utils": "^8.3.0",
     "@metamask/superstruct": "^3.1.0",
     "@metamask/utils": "^11.0.1",
-    "@types/uuid": "^9.0.8",
-    "uuid": "^9.0.1",
-    "webextension-polyfill": "^0.12.0"
+    "uuid": "^9.0.1"
   },
   "devDependencies": {
-    "@lavamoat/allow-scripts": "^3.2.1",
-    "@lavamoat/preinstall-always-fail": "^2.1.0",
-    "@metamask/auto-changelog": "^3.4.4",
     "@metamask/providers": "^18.3.1",
     "@ts-bridge/cli": "^0.6.1",
     "@types/jest": "^29.5.12",
     "@types/node": "^20.12.12",
+    "@types/uuid": "^9.0.8",
     "deepmerge": "^4.2.2",
     "depcheck": "^1.4.7",
     "jest": "^29.5.0",
@@ -68,10 +63,10 @@
     "ts-node": "^10.9.2",
     "tsd": "^0.31.0",
     "typedoc": "^0.25.13",
-    "typescript": "~5.6.3"
+    "typescript": "~5.6.3",
+    "webextension-polyfill": "^0.12.0"
   },
   "peerDependencies": {
-    "@metamask/keyring-api": "workspace:^",
     "@metamask/providers": "^18.3.1"
   },
   "engines": {

diff --git a/packages/keyring-snap-client/package.json b/packages/keyring-snap-client/package.json
@@ -45,22 +45,22 @@
     "test:watch": "jest --watch"
   },
   "dependencies": {
-    "@metamask/keyring-api": "workspace:^",
     "@metamask/keyring-utils": "workspace:^",
     "@metamask/superstruct": "^3.1.0",
-    "@types/uuid": "^9.0.8",
     "uuid": "^9.0.1",
     "webextension-polyfill": "^0.12.0"
   },
   "devDependencies": {
     "@lavamoat/allow-scripts": "^3.2.1",
     "@lavamoat/preinstall-always-fail": "^2.1.0",
     "@metamask/auto-changelog": "^3.4.4",
+    "@metamask/keyring-api": "workspace:^",
     "@metamask/providers": "^18.3.1",
     "@metamask/utils": "^11.0.1",
     "@ts-bridge/cli": "^0.6.1",
     "@types/jest": "^29.5.12",
     "@types/node": "^20.12.12",
+    "@types/uuid": "^9.0.8",
     "deepmerge": "^4.2.2",
     "depcheck": "^1.4.7",
     "jest": "^29.5.0",
@@ -73,6 +73,7 @@
     "typescript": "~5.6.3"
   },
   "peerDependencies": {
+    "@metamask/keyring-api": "workspace:^",
     "@metamask/providers": "^18.3.1"
   },
   "engines": {

diff --git a/packages/keyring-snap-sdk/package.json b/packages/keyring-snap-sdk/package.json
@@ -46,7 +46,6 @@
   },
   "dependencies": {
     "@metamask/keyring-utils": "workspace:^",
-    "@metamask/snaps-sdk": "^6.7.0",
     "@metamask/superstruct": "^3.1.0",
     "@metamask/utils": "^11.0.1",
     "webextension-polyfill": "^0.12.0"
@@ -57,6 +56,7 @@
     "@metamask/auto-changelog": "^3.4.4",
     "@metamask/keyring-api": "workspace:^",
     "@metamask/providers": "^18.3.1",
+    "@metamask/snaps-sdk": "^6.7.0",
     "@ts-bridge/cli": "^0.6.1",
     "@types/jest": "^29.5.12",
     "@types/node": "^20.12.12",
@@ -72,6 +72,7 @@
     "typescript": "~5.6.3"
   },
   "peerDependencies": {
+    "@metamask/keyring-api": "workspace:^",
     "@metamask/providers": "^18.3.1"
   },
   "engines": {

diff --git a/yarn.lock b/yarn.lock
@@ -1883,6 +1883,7 @@ __metadata:
     deepmerge: "npm:^4.2.2"
     ethereum-cryptography: "npm:^2.1.2"
     jest: "npm:^29.5.0"
+    typescript: "npm:~5.6.3"
   languageName: unknown
   linkType: soft
 
@@ -1994,12 +1995,8 @@ __metadata:
   resolution: "@metamask/eth-snap-keyring@workspace:packages/keyring-snap-bridge"
   dependencies:
     "@ethereumjs/tx": "npm:^4.2.0"
-    "@lavamoat/allow-scripts": "npm:^3.2.1"
-    "@lavamoat/preinstall-always-fail": "npm:^2.1.0"
-    "@metamask/auto-changelog": "npm:^3.4.4"
     "@metamask/eth-sig-util": "npm:^8.1.2"
     "@metamask/keyring-api": "workspace:^"
-    "@metamask/keyring-internal-api": "workspace:^"
     "@metamask/keyring-internal-snap-client": "workspace:^"
     "@metamask/keyring-utils": "workspace:^"
     "@metamask/providers": "npm:^18.3.1"
@@ -2024,7 +2021,6 @@ __metadata:
     uuid: "npm:^9.0.1"
     webextension-polyfill: "npm:^0.12.0"
   peerDependencies:
-    "@metamask/keyring-api": "workspace:^"
     "@metamask/providers": ^18.3.1
   languageName: unknown
   linkType: soft
@@ -2062,6 +2058,8 @@ __metadata:
     tslib: "npm:^2.6.2"
     typedoc: "npm:^0.25.13"
     typescript: "npm:~5.6.3"
+  peerDependencies:
+    tslib: ^2.6.2
   languageName: unknown
   linkType: soft
 
@@ -2150,7 +2148,6 @@ __metadata:
     "@ts-bridge/cli": "npm:^0.6.1"
     "@types/jest": "npm:^29.5.12"
     "@types/node": "npm:^20.12.12"
-    "@types/webextension-polyfill": "npm:^0.12.1"
     bech32: "npm:^2.0.0"
     deepmerge: "npm:^4.2.2"
     depcheck: "npm:^1.4.7"
@@ -2164,7 +2161,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@metamask/keyring-internal-api@workspace:^, @metamask/keyring-internal-api@workspace:packages/keyring-internal-api":
+"@metamask/keyring-internal-api@workspace:packages/keyring-internal-api":
   version: 0.0.0-use.local
   resolution: "@metamask/keyring-internal-api@workspace:packages/keyring-internal-api"
   dependencies:
@@ -2188,6 +2185,8 @@ __metadata:
     tsd: "npm:^0.31.0"
     typedoc: "npm:^0.25.13"
     typescript: "npm:~5.6.3"
+  peerDependencies:
+    "@metamask/keyring-api": "workspace:^"
   languageName: unknown
   linkType: soft
 
@@ -2254,6 +2253,7 @@ __metadata:
     uuid: "npm:^9.0.1"
     webextension-polyfill: "npm:^0.12.0"
   peerDependencies:
+    "@metamask/keyring-api": "workspace:^"
     "@metamask/providers": ^18.3.1
   languageName: unknown
   linkType: soft
@@ -2286,6 +2286,7 @@ __metadata:
     typescript: "npm:~5.6.3"
     webextension-polyfill: "npm:^0.12.0"
   peerDependencies:
+    "@metamask/keyring-api": "workspace:^"
     "@metamask/providers": ^18.3.1
   languageName: unknown
   linkType: soft
@@ -3678,13 +3679,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/webextension-polyfill@npm:^0.12.1":
-  version: 0.12.1
-  resolution: "@types/webextension-polyfill@npm:0.12.1"
-  checksum: 10/80c1f81af272d378098474a41e0941bf9375261423ea289cd8250efc9a628cec4fa6083cb9cd5c62ff0f828ac235a044c0b95543c0606e894dfd485cea55b0aa
-  languageName: node
-  linkType: hard
-
 "@types/ws@npm:^7.2.0, @types/ws@npm:^7.4.4":
   version: 7.4.7
   resolution: "@types/ws@npm:7.4.7"