This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Restore compatibility with QR Keyring #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jul 18, 2023
The `KeyringController` method `addNewKeyring` was changed in v11 to initialize the keyring options to an empty object. These options are passed to the `deserialize` method of the keyring. This broke compatibility with the QR keyring because its `deserialize` method does not expect to be passed an empty object. The `KeyringController` has been updated to no longer initialize the `addNewKeyring` options to an empty object. It should now work the same as it did prior to v11. The one functional difference is that it now throws an error when `addNewKeyring` is used to add a simple keyring without supplying any private keys, however that path would have already thrown an error.
Gudahtt
force-pushed
the
fix-qr-keyring-compatibility
branch
from
9ebdc0f
to
836b5a4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
KeyringControllermethodaddNewKeyringwas changed in v11 to initialize the keyring options to an empty object. These options are passed to thedeserializemethod of the keyring. This broke compatibility with the QR keyring because itsdeserializemethod does not expect to be passed an empty object.The
KeyringControllerhas been updated to no longer initialize theaddNewKeyringoptions to an empty object. It should now work the same as it did prior to v11. The one functional difference is that it now throws an error whenaddNewKeyringis used to add a simple keyring without supplying any private keys, however that path would have already thrown an error.Changes
addNewKeyringincompatbility when no options are providedaddNewKeyringmethod stopped working with certain keyrings (e.g. the QR keyring) in v11 when called with no options.References
This bug was introduced before and fixed in the past, e.g. #136
Checklist