This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Fix signTypedMessage parameter types
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Gudahtt
force-pushed
the
fix-sign-typed-data-parameter-types
branch
from
1917724
to
7086099
Compare
The `signTypedMessage` parameter types accepted the data to sign as an array. This works with `signTypedData_v1`, but is incompatible with later versions. The signature has been updated to accept data as either an array or an object. Additionally, tests have been added to cover all three supported versions of `signTypedData`.
Gudahtt
force-pushed
the
fix-sign-typed-data-parameter-types
branch
from
7086099
to
e5a0f56
Compare
mikesposito
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
signTypedMessageparameter types accepted the data to sign as an array. This works withsignTypedData_v1, but is incompatible with later versions.The signature has been updated to accept data as either an array or an object. Additionally, tests have been added to cover all three supported versions of
signTypedData.Changes
signTypedMessagenow accepts data either as an array or an objectReferences
Helps to unblock MetaMask/core#1441
Checklist