Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Payment request #57

Closed
omnat opened this issue Apr 2, 2019 · 16 comments
Closed

Payment request #57

omnat opened this issue Apr 2, 2019 · 16 comments

Comments

@omnat
Copy link
Collaborator

omnat commented Apr 2, 2019

Brief: https://docs.google.com/document/d/1e1w93XkXFnpiSg4nuj-S36jGSimlHGiAaxu5YCcD_mA/edit#heading=h.z5etji6xe44v

@omnat to walkthrough this with CJ
Conditional user testing (depending if the design is a new pattern)

@omnat omnat added mobile Related to mobile app needs user testing labels Apr 2, 2019
@omnat omnat self-assigned this Apr 2, 2019
@omnat omnat added this to the Sprint 4.1 - 4.12 milestone Apr 2, 2019
@bdresser
Copy link

in public beta, may want to link out to the Simplex page as an option for fiat onboarding

relates to MetaMask/metamask-extension#4867

@cjeria
Copy link
Contributor

cjeria commented Apr 24, 2019

Gif of the initial lo-fi prototype of the payment request feature that @omnat's been testing.

@bdresser
Copy link

bdresser commented Apr 24, 2019

what about a "Show QR" option in addition to Send & Copy?

I see the QR option on the previous tray, but it'd be nice to also be able to encode an entire transaction (can I have .5 ETH) and just show that to a friend, who could scan & just tap "Confirm"

Also not super keen on the copy
Receiver will need the link below to send requested amount

  • either party could be the "receiver"
  • they don't actually need the link , they could always do this manually?
  • maybe something like Send this link to a friend, and it will ask them to send [X ETH] to [Account Name]

@bdresser
Copy link

From design sync

  • Add gas fee on top of the requested amount
  • Add option to change asset being requested (maybe a simple drop down with autocomplete)
  • Flow for when the other user taps a link
    • Drops other user in edit/send screen with amount, asset, address pre-populated
    • Ideally is possible to open the link in other apps as well

@omnat
Copy link
Collaborator Author

omnat commented Apr 29, 2019

From design sync:

  • visual design pass on the sender flow

Design receiver flow in different issue #83

@omnat omnat removed their assignment Apr 29, 2019
@cjeria
Copy link
Contributor

cjeria commented May 2, 2019

@bdresser @brunobar79 we're not considering NFT's for the request flow right?

@cjeria
Copy link
Contributor

cjeria commented May 6, 2019

Updated payment request flow.

Up next:

  • Adding ETH to fiat swapper
  • If sending tokens, need to represent the token value + fiat conversion
  • Consider adding token symbols to request amount screen
  • Custom icons on the first receive option screen

@cjeria
Copy link
Contributor

cjeria commented May 6, 2019

Here's an updated design. If the user selects a token to send, display the token symbol in the amount screen.

@omnat
Copy link
Collaborator Author

omnat commented May 6, 2019

User test outcome below. Suggestion to highlight one of the 3 options on the last screen to inspire finishing of action. And the standard practice to add a confirmation after request is sent.

Question: will this sent request be stored in user's history? E.g., as a user, can I see all the requests I've made in the past and status on those (which ones succeeded, which ones rejected, and which ones pending..)? @cjeria

Payment request (2)

@estebanmino
Copy link

We can surely save the information of the requests that an user has sent.

which ones succeeded, which ones rejected, and which ones pending: we don't have the architecture to do this yet, as a payment request receiver you'll be able to send the transaction but not be able to directly (through MM) reply the status of it, yet.

@cjeria
Copy link
Contributor

cjeria commented May 7, 2019

Updated request page per user research @omnat
image

@bdresser
Copy link

bdresser commented May 7, 2019

This looks great @cjeria!

Question for esteban and bruno: do you think the link will be as short as the one shown, or should we design for the case where the link ends up super long (and give a ... in the middle or something) ?

Question: will this sent request be stored in user's history? E.g., as a user, can I see all the requests I've made in the past and status on those (which ones succeeded, which ones rejected, and which ones pending..)?

We could theoretically show each of these links in the users tx history as a request ? But as esteban points out, we won't know much additional information about these requests, even basic stuff like who they sent it to, or whether or not the other user completes the tx. I think we should hold off on any dedicated management screens for these until we have more robust features like in-app messaging.

@estebanmino
Copy link

I think the second case would be the best here, for example to send 1 ETH in mainnet we have

ethereum:0x56CED0d816c668d7c0ccc3FBF0aB2c6896F589a2@1?value=1e18

that won't fit in all devices screens in the same way. Furthermore, we have ERC20 tokens, a edge case for that would be an user sending an amount with many decimal places or large amount of tokens.

Bruno made this generator that is online here https://brunobar79.github.io/eip681-link-generator/#, we're going to use the same logic behind it.

@bdresser
Copy link

bdresser commented May 8, 2019

Fimga link

@bdresser
Copy link

bdresser commented May 8, 2019

q's from @estebanmino

  • on the partial modal, we have an X that isn't on other partial modals -- should we keep?
  • how do we decide which tokens we want to show on the "pick asset" screen? maybe just show search box? @cjeria to think about a little bit more
  • @cjeria to combine QR presentations to a single modal
  • when you tap the receive + button in an asset view, we should take the user to the same four-tile screen

@estebanmino
Copy link

@cjeria RE how do we decide which tokens we want to show on the "pick asset" screen?:
While we wait for final designs I implemented both options in one as we talked today.

SNnCZLOzyi

Dai and ETH are assets by default, combined with a new search asset component that we can modify to match designs.

@bdresser bdresser closed this as completed Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants