Fix the issue where TLS Sniffer fails when the length of the ClientHello packet exceeds the TCP MSS #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the length of the ClientHello message exceeds the TCP MSS (usually 1460 or 1448), due to the fragmentation of the ClientHello message during transmission, it may prevent TLSSniffer from obtaining sufficient data in first peek to parse the packet, leading to parsing failure.
Solution:
During the TLS Sniffer parsing process, the required packet length can be determined. If the first parsing attempt fails, a retry can be initiated. Within a timeout period, once the data of the corresponding length is obtained, re-parsing can be performed.