Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve strengthening to get cumul info on type #985

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

tabareau
Copy link
Member

No description provided.

@MevenBertrand
Copy link
Member

We did not use it anywhere, so this is probably nitpicking, but the new phrasing is in some respect weaker than the old one: it does not say anything about terms which have only variable in Δ but a type living in Γ, only about the situation where both the term and the type live in Δ. I'm not sure how to phrase a theorem that would encompass this situation and give you what you want (ie a relation between the old and new type), but maybe:

Theorem typing_renaming_cond_P `{checker_flags} {P f Σ Γ Δ t T} {wfΣ : wf Σ.1} :
  renaming P Σ Γ Δ f ->
  on_ctx_free_vars P Γ ->
  on_free_vars P t ->
  Σ ;;; Γ |- t : T ->
  ∑ T', [× (on_free_vars P T'), (Σ ;;; Γ |- t : T'), (Σ ;;; Γ |- T' <= T) &
  (Σ ;;; Δ |- rename f t : rename f T')].

@tabareau
Copy link
Member Author

@MevenBertrand thx for the comment. Looks good to you now ?

@MevenBertrand
Copy link
Member

LGTM! At least, the new version trivially implies the old one. Not entirely happy about having two typing judgements for t and T', one in Γ and one in Δ, but I guess this really is the "strengthening" bit so it is unavoidable.

@tabareau tabareau merged commit 46be926 into coq-8.17 Sep 27, 2023
8 checks passed
@tabareau tabareau deleted the improve-strengthening branch September 27, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants