-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universes clause check #704
Draft
mattam82
wants to merge
33
commits into
coq-8.14
Choose a base branch
from
universes-clause-check
base: coq-8.14
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename Constraint to LevelConstraint, preparing for a later move to general universe constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new loop-checking algorithm to MetaCoq, which should allow to handle arbitrary universe constraints efficiently, e.g.
max (u + 1, v) = max (j, k+ 2)
. It is based on a constructive proof by Bezem et Coquand for the slightly more general problem of building a model inN^∞
of a set of horn clauses of shapeu + k \/ ... \/ l + n -> l' + k'
. This can be restricted to check if a loop follows from a set of constraints or if we have a model inN
, which can in turn be seen as a valuation of the clauses making them all (non-vacuously) true.The algorithm is currently only shown to be terminating and to return a valid model when it finds one, but it might also answer
Loop
, in which case we have not (yet) proven that there is indeed a loop.I added a new extracted plugin in the test-suite (based on plugin-demo), that provides a new command
MetaCoq Check Universes
that checks for a model using the new algorithm on all the constraints in the global environment at the point of the call. It currently takes < 0.5s to verify that there is a valuation with 4 distinct universes for all the universes and constraints in Coq's standard library.