Remove bugged option MetaCoq Template Monad Debug. #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes coq/vscoq#892 because `optwrite` is not supposed to be able to add persistent objects (libobject) to Coq's state but `set_option_value` does add one. It's also bugged as `set_option_value ~stage:Interp (fun _ v -> v) key i` sets the option to its current value not a new value. In other words `Set MetaCoq Template Monad Debug.` has no effect but its existence causes bugs. Since nobody complained about it not working it's not worth fixing it instead of deleting it (also I'm not sure it can be fixed with the currently available APIs).
|
If it's not broken don't fix it but if it's not used remove it! |
SkySkimmer
added a commit
to SkySkimmer/coq
that referenced
this pull request
Jan 14, 2025
- use GADT to control the type of the value - remove "Set ... Append" command, instead appending is a behaviour of the given option (currently Warnings and Debug) - expose API for unsynchronized options (would allow to fix the code in MetaCoq/metacoq#1123 instead of removing it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes coq/vscoq#892 because
optwriteis not supposed to be able to add persistent objects (libobject) to Coq's state butset_option_valuedoes add one.It's also bugged as
set_option_value ~stage:Interp (fun _ v -> v) key isets the option to its current valuevnot a new valuei. In other wordsSet MetaCoq Template Monad Debug.has no effect but its existence causes bugs.Since nobody complained about it not working it's not worth fixing it instead of deleting it (also I'm not sure it can be fixed with the currently available APIs).