-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lumino adv tree #9
Lumino adv tree #9
Conversation
This is saved along with the Lumino layout for restoring after navigation. Implemented for the log view only so far.
src/views/Log.vue
Outdated
if (!taskTokens?.task) { | ||
if (!taskTokens || !taskTokens.task) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
src/views/Tree.vue
Outdated
/** | ||
* The selection expand/collapse option. | ||
* @type {import('vue').Ref<string>} | ||
*/ | ||
const expandAll = useInitialOptions('expandAll', { props, emit }, ref(null)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to store this, as this is not really a setting but a trigger. For example, a user could click collapse all, then expand a selection of nodes. If they navigated away then back, they would find all nodes collapsed again. We don't currently have a way to store the expanded/collapsed state of every node in the tree as a whole.
/** | |
* The selection expand/collapse option. | |
* @type {import('vue').Ref<string>} | |
*/ | |
const expandAll = useInitialOptions('expandAll', { props, emit }, ref(null)) | |
/** | |
* Setting this to an empty array causes all nodes to collapse. | |
* Setting it to an array of node types causes those node types to expand. | |
* @type {import('vue').Ref<string[]|null>} | |
*/ | |
const expandAll = ref(null) |
src/views/Tree.vue
Outdated
|
||
/** | ||
* The job id input and selected task filter state. | ||
* @type {import('vue').Ref<string>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @type {import('vue').Ref<string>} | |
* @type {import('vue').Ref<Object>} |
This branch has been merged so now need to open a PR against master. Can you rebase onto master & squash the commits down before opening the PR please |
These changes build on the work undertaken to save & restore workspace layout on navigation cylc#1664
Which is part of a larger issue cylc#662
There is an equivalent pull request for the tree view cylc#1688
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.