Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table view: use initialOptions to save & restore view state on navigation #8

Closed
wants to merge 3 commits into from
Closed

Table view: use initialOptions to save & restore view state on navigation #8

wants to merge 3 commits into from

Conversation

markgrahamdawson
Copy link

@markgrahamdawson markgrahamdawson commented Feb 29, 2024 •
edited
Loading

Extends the pull request
cylc#1688

Which
Closes cylc#1278
Partially addresses cylc#662

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Already covered by existing tests.
  • Does not need tests (why?).
  • Appropriate change log entry included.
  • No change log entry required (why? e.g. invisible to users).
  • I have opened a documentation PR at cylc/cylc-doc/pull/XXXX.
  • No documentation update required.

MetRonnie and others added 3 commits February 15, 2024 17:44
@MetRonnie
Use initialOptions prop to save view state
97e33fd 
This is saved along with the Lumino layout for restoring after navigation.

Implemented for the log view only so far.
@MetRonnie
Log view: don't query files in job log mode when no ID given
0152228
@markgrahamdawson
import initialOptions for table view
2bdaa30
@markgrahamdawson markgrahamdawson changed the title import initialOptions for table view Table view: use initialOptions to save & restore view state on navigation Feb 29, 2024
@MetRonnie MetRonnie self-requested a review March 1, 2024 11:07
@MetRonnie MetRonnie deleted the branch MetRonnie:lumino-adv March 12, 2024 11:36
@MetRonnie MetRonnie closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie Awaiting requested review from MetRonnie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markgrahamdawson @MetRonnie