More leniant handling on the binary expression copying

- Only create a new intermediate value when we captured a scope that hasn't already necessarily created a new intermediate variable
MerlinVR · Apr 7, 2020 · 3670343 · 3670343
1 parent 8ffa1ca
commit 3670343
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/Assets/UdonSharp/Editor/UdonSharpASTVisitor.cs b/Assets/UdonSharp/Editor/UdonSharpASTVisitor.cs
@@ -1574,15 +1574,22 @@ public override void VisitBinaryExpression(BinaryExpressionSyntax node)
             {
                 Visit(node.Left);
 
-                // This needs to be copied because someone can do an in place assignment operator on the rhs that changes the lhs value
-                SymbolDefinition lhsCopy = visitorContext.topTable.CreateUnnamedSymbol(lhsCapture.GetReturnType(true), SymbolDeclTypeFlags.Internal);
-                using (ExpressionCaptureScope lhsCopySetter = new ExpressionCaptureScope(visitorContext, null))
+                if (lhsCapture.DoesReturnIntermediateSymbol())
                 {
-                    lhsCopySetter.SetToLocalSymbol(lhsCopy);
-                    lhsCopySetter.ExecuteSetDirect(lhsCapture);
+                    lhsValue = lhsCapture.ExecuteGet();
                 }
+                else
+                {
+                    // This needs to be copied because someone can do an in place assignment operator on the rhs that changes the lhs value
+                    SymbolDefinition lhsCopy = visitorContext.topTable.CreateUnnamedSymbol(lhsCapture.GetReturnType(true), SymbolDeclTypeFlags.Internal);
+                    using (ExpressionCaptureScope lhsCopySetter = new ExpressionCaptureScope(visitorContext, null))
+                    {
+                        lhsCopySetter.SetToLocalSymbol(lhsCopy);
+                        lhsCopySetter.ExecuteSetDirect(lhsCapture);
+                    }
 
-                lhsValue = lhsCopy;
+                    lhsValue = lhsCopy;
+                }
 
                 using (ExpressionCaptureScope rhsCapture = new ExpressionCaptureScope(visitorContext, null))
                 {

diff --git a/Assets/UdonSharp/Editor/UdonSharpExpressionCapture.cs b/Assets/UdonSharp/Editor/UdonSharpExpressionCapture.cs
@@ -1414,6 +1414,11 @@ public System.Type GetReturnType(bool getUserType = false)
             }
         }
 
+        public bool DoesReturnIntermediateSymbol()
+        {
+            return !IsLocalSymbol();
+        }
+
         public bool ResolveAccessToken(string accessToken)
         {
             bool resolvedToken = false;