Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stack-setup): put hooks at the right place #549

Conversation

sileht
Copy link
Member

@sileht sileht commented Nov 20, 2024

This adds test coverage to stack_setup to ensure we don't break this
again.

This adds test coverage to stack_setup to ensure we don't break this
again.

Change-Id: Iffd484d926e55f5136d19e02f203ca3aab82b438
Copy link
Contributor

mergify bot commented Nov 20, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team November 20, 2024 07:48
@mergify mergify bot merged commit 427ccc6 into main Nov 20, 2024
5 checks passed
@mergify mergify bot added the queued label Nov 20, 2024
@mergify mergify bot deleted the devs/sileht/build-sys-new/Iffd484d926e55f5136d19e02f203ca3aab82b438 branch November 20, 2024 08:21
@mergify mergify bot removed the queued label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants