Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better attachment support #135

Merged
merged 4 commits into from
Nov 1, 2024
Merged

better attachment support #135

merged 4 commits into from
Nov 1, 2024

Conversation

ldub
Copy link
Contributor

@ldub ldub commented Sep 15, 2024

Having read a lot of Slack documentation and operated v2.0.0.3 in production for a bit, I now understand that the Slack message attachment field is poorly standardized. None of the fields are required and there are different versions of the attachments api over the years that are all supported in this one field.

To make apps that look at attachments, chance are, you're going to need to look at the raw json value. So I've edited slack-web to try to decode the attachment based on documented schema (and ported from Slack's own open source javascript sdks) but then also pass the raw json value to clients.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@ldub ldub merged commit 649186a into master Nov 1, 2024
4 checks passed
@ldub ldub deleted the lev/more-attachments branch November 1, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant