Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate 'Codable' bounds through MoatData tyvars #75

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

tadfisher
Copy link
Collaborator

Fixes #73

Similar to the work done in #50, propagate the Codable upper bound through MoatData type variables in generated Swift; this is required to support generic data types with Codable.

@tadfisher tadfisher force-pushed the tad/generic-newtype-test branch from a7cb12f to 10b09dd Compare January 29, 2024 22:41
Copy link
Collaborator

@chiroptical chiroptical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for my questions to get resolved in another PR.

src/Moat/Pretty/Swift.hs Outdated Show resolved Hide resolved
@tadfisher tadfisher force-pushed the tad/generic-newtype-test branch from 394b222 to 848c9c6 Compare January 30, 2024 22:23
src/Moat/Pretty/Swift.hs Outdated Show resolved Hide resolved
@tadfisher tadfisher force-pushed the tad/generic-newtype-test branch from 848c9c6 to 5623116 Compare January 30, 2024 22:32
@tadfisher tadfisher requested a review from chiroptical January 30, 2024 22:33
@tadfisher tadfisher force-pushed the tad/generic-newtype-test branch from 5623116 to 87c52ed Compare January 30, 2024 22:44
@tadfisher tadfisher merged commit 4d5d79b into master Feb 1, 2024
21 checks passed
@tadfisher tadfisher deleted the tad/generic-newtype-test branch February 1, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model type variable bounds
3 participants