Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Poetry 1.2 dependency group for dev dependencies #8

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

Tenzer
Copy link
Member

@Tenzer Tenzer commented Sep 6, 2022

@meshy
Copy link
Collaborator

meshy commented Sep 6, 2022

It looks like we're hitting this issue: sinoroc/tox-poetry-dev-dependencies#62

@Tenzer
Copy link
Member Author

Tenzer commented Sep 6, 2022

Yes, I found that as well. I was thinking we don't need to use tox in CI because each Python version is tested in its own runner anyways. Any objections to removing tox from the CI?

@meshy
Copy link
Collaborator

meshy commented Sep 6, 2022

I used tox to avoid configuring the tests in two places, but suppose it's not worth the cost now. No objections!

@Tenzer Tenzer merged commit 5431b8b into main Sep 6, 2022
@Tenzer Tenzer deleted the poetry-1.2 branch September 6, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants