Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit on Python version #7

Closed
wants to merge 1 commit into from
Closed

Conversation

meshy
Copy link
Collaborator

@meshy meshy commented Aug 26, 2022

This makes the library easier to install on projects managed by Poetry,
which would otherwise fail with an error like:

SolverProblemError

The current project's Python requirement (>=3.10,<4.0) is not compatible with some of the required packages Python requirement:
  - mypy-json-report requires Python >=3.7,<3.11, so it will not be satisfied for Python >=3.11,<4.0

Because mypy-json-report (0.1.2) requires Python >=3.7,<3.11
 and no versions of mypy-json-report match >0.1.2,<0.2.0, mypy-json-report is forbidden.
So, because $PROJECT_NAME depends on mypy-json-report (^0.1.2), version solving failed.

@meshy meshy requested a review from jml September 6, 2022 09:35
This makes the library easier to install on projects managed by Poetry,
which would otherwise fail with an error like:

    SolverProblemError

    The current project's Python requirement (>=3.10,<4.0) is not compatible with some of the required packages Python requirement:
      - mypy-json-report requires Python >=3.7,<3.11, so it will not be satisfied for Python >=3.11,<4.0

    Because mypy-json-report (0.1.2) requires Python >=3.7,<3.11
     and no versions of mypy-json-report match >0.1.2,<0.2.0, mypy-json-report is forbidden.
    So, because $PROJECT_NAME depends on mypy-json-report (^0.1.2), version solving failed.
@meshy meshy force-pushed the broader-version-support branch from db84993 to 8b85347 Compare September 6, 2022 09:45
@meshy
Copy link
Collaborator Author

meshy commented Sep 6, 2022

Thanks for the approval. It now looks like we're hitting an issue with a test dependency. sinoroc/tox-poetry-dev-dependencies#62

I'll get back to this.

@Tenzer
Copy link
Member

Tenzer commented Sep 6, 2022

The dependency problems should have been sorted out now. I have made #11 which removes the upper version boundary and adds Python 3.11 to the test matrix.

@meshy
Copy link
Collaborator Author

meshy commented Sep 6, 2022

Thanks! I'll close this in favour of your PR.

@meshy meshy closed this Sep 6, 2022
@Tenzer Tenzer deleted the broader-version-support branch September 6, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants