Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple enhancements. #64

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Add multiple enhancements. #64

merged 3 commits into from
Sep 8, 2023

Conversation

jealous
Copy link
Contributor

@jealous jealous commented Sep 8, 2023 •
edited
Loading

  • Add the cpuFactor and memoryFactor option to tune the settings.
  • Unify the code of process job status.
  • Properly handle the quoted parameters.

@jealous jealous self-assigned this Sep 8, 2023
@jealous
Add cpu/memory factor
7bc44f3 
Add float options to tune the cpu & memory settings.

Add a new tag to track the total size of the task input.
@jealous
Do not update the job status when it's finished
dbf06b5 
Always refresh the work directory when job finished is received.
@jealous jealous force-pushed the bugfix/syncFloatBin branch from 510801d to 0650c7b Compare September 8, 2023 07:33
@jealous
Handle quoted params in extra.
2b117c4 
Properly handle the quoted parameters in `extra` or `commonExtra`.
@jealous jealous force-pushed the bugfix/syncFloatBin branch from 0650c7b to 2b117c4 Compare September 8, 2023 07:43
@jealous jealous merged commit 0036d96 into master Sep 8, 2023
1 check passed
@jealous jealous deleted the bugfix/syncFloatBin branch September 8, 2023 07:57
jealous added a commit to jealous/plugins that referenced this pull request Oct 12, 2023
@jealous
Update nf-float plugin to 0.4.0
863485a 
* Report RC code when MMC returns error. by @jealous in MemVerge/nf-float#59
* Download float cli from op-center. by @jealous in MemVerge/nf-float#60
* Try the best to fix s3 options. by @jealous in MemVerge/nf-float#61
* sync the float binary. by @jealous in MemVerge/nf-float#62
* Add multiple enhancements. by @jealous in MemVerge/nf-float#64
* Allow user to omit credentials. by @jealous in MemVerge/nf-float#65
* Trim extra characters in image. by @jealous in MemVerge/nf-float#66
* Add max cpu and memory factor support. by @jealous in MemVerge/nf-float#67
* Add job kind tag to identify the kind of the job. by @jealous in MemVerge/nf-float#68

**Full Changelog**: MemVerge/nf-float@0.3.1...0.4.0
@jealous jealous mentioned this pull request Oct 12, 2023
Merged
pditommaso pushed a commit to nextflow-io/plugins that referenced this pull request Oct 12, 2023
@jealous
Update nf-float plugin to 0.4.0 (#41)
73bdf34 
* Report RC code when MMC returns error. by @jealous in MemVerge/nf-float#59
* Download float cli from op-center. by @jealous in MemVerge/nf-float#60
* Try the best to fix s3 options. by @jealous in MemVerge/nf-float#61
* sync the float binary. by @jealous in MemVerge/nf-float#62
* Add multiple enhancements. by @jealous in MemVerge/nf-float#64
* Allow user to omit credentials. by @jealous in MemVerge/nf-float#65
* Trim extra characters in image. by @jealous in MemVerge/nf-float#66
* Add max cpu and memory factor support. by @jealous in MemVerge/nf-float#67
* Add job kind tag to identify the kind of the job. by @jealous in MemVerge/nf-float#68

**Full Changelog**: MemVerge/nf-float@0.3.1...0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jealous jealous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jealous