Add support for several process directives #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #27
This PR adds support for the following process directives:
While the CLI options can already be specified via
float.commonExtra
, the process directives are more user-friendly and can also be applied on a per-process level.Also adds custom config options for
--vmPolicy
and--migratePolicy
, since these options are some of the most valuable parts of Float but also have the most complicated syntax, we should try to make them as user-friendly as possible.I also added a few default labels for things like process name, task name, session ID, etc. But feel free to remove them if you don't think they are needed. I copied them from the K8s executor.
I added unit tests for these options but haven't tested them end to end. Let me know if you need any help with testing.
Not urgent or groundbreaking but these settings would be nice to have for the initial blog post.