Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for unified setup #10

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

edwinyyyu
Copy link
Contributor

No description provided.

@edwinyyyu edwinyyyu marked this pull request as ready for review September 10, 2024 01:51
Copy link
Collaborator

@svetly-todorov svetly-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, just a few thoughts on one of the new Ansible sections


In an inventory file (which can be named anything), configure the two groups:
- **`[all]`**
A list of the hosts that will participate in the Kubernetes cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For [all], maybe add an indented section like

Note:
The [all] group of this file will be identical to the one in deepops/config/inventory when installing Kubernetes via DeepOps.
If DeepOps was not used to install Kubernetes, follow these instructions:

Also, nitpicks,
configuraiton -> configuration
configure the two groups -> configure two groups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants