Remove resource defaults for flyte-binary deployment in flyte-binary …

…chart (flyteorg#3392) Signed-off-by: Jeev B <[email protected]>
MemVerge · Mar 4, 2023 · 5016298 · 5016298
1 parent 86fa407
commit 5016298
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 32 deletions.
diff --git a/charts/flyte-binary/README.md b/charts/flyte-binary/README.md
@@ -78,8 +78,6 @@ Chart for basic single Flyte executable deployment
 | deployment.podSecurityContext.runAsGroup | int | `65534` |  |
 | deployment.podSecurityContext.runAsUser | int | `65534` |  |
 | deployment.readinessProbe | object | `{}` |  |
-| deployment.resources.limits.memory | string | `"1Gi"` |  |
-| deployment.resources.requests.cpu | int | `1` |  |
 | deployment.sidecars | list | `[]` |  |
 | deployment.startupProbe | object | `{}` |  |
 | deployment.waitForDB.args | list | `[]` |  |

diff --git a/charts/flyte-binary/values.yaml b/charts/flyte-binary/values.yaml
@@ -154,11 +154,12 @@ deployment:
   # lifecycleHooks Specify hooks to run in Flyte container before or after startup
   lifecycleHooks: {}
   # resources Resource limits and requests for Flyte container
-  resources:
-    limits:
-      memory: 1Gi
-    requests:
-      cpu: 1
+  # Uncomment and update to specify resources for deployment
+  # resources:
+  #   limits:
+  #     memory: 1Gi
+  #   requests:
+  #     cpu: 1
   # podSecurityContext Specify security context for Flyte pod
   # See: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
   podSecurityContext:

diff --git a/charts/flyte-sandbox/Chart.lock b/charts/flyte-sandbox/Chart.lock
@@ -15,4 +15,4 @@ dependencies:
   repository: https://charts.bitnami.com/bitnami
   version: 12.1.9
 digest: sha256:e7155e540bbdb98f690eb12e2bd301a19d8b36833336f6991410cb44d8d9bb5e
-generated: "2023-02-22T21:45:07.411055-08:00"
+generated: "2023-03-02T20:34:57.944033-08:00"
diff --git a/charts/flyte-sandbox/charts/flyte-binary-v0.1.10.tgz b/charts/flyte-sandbox/charts/flyte-binary-v0.1.10.tgz
diff --git a/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml b/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
@@ -322,11 +322,6 @@ spec:
                 echo waiting for database
                 sleep 0.1
               done
-          resources:
-            limits:
-              memory: 1Gi
-            requests:
-              cpu: 1
       containers:
         - name: flyte
           image: "ghcr.io/flyteorg/flyte-binary:latest"
@@ -359,11 +354,6 @@ spec:
             httpGet:
               path: /healthcheck
               port: http
-          resources:
-            limits:
-              memory: 1Gi
-            requests:
-              cpu: 1
           volumeMounts:
             - name: cluster-resource-templates
               mountPath: /etc/flyte/cluster-resource-templates

diff --git a/docker/sandbox-bundled/manifests/complete.yaml b/docker/sandbox-bundled/manifests/complete.yaml
@@ -758,7 +758,7 @@ type: Opaque
 ---
 apiVersion: v1
 data:
-  haSharedSecret: VnZiU0xIZjBLRVcxcjI0Zw==
+  haSharedSecret: YnFuQzZJbUdEQVo3VkhsaQ==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -1172,11 +1172,6 @@ spec:
           httpGet:
             path: /healthcheck
             port: http
-        resources:
-          limits:
-            memory: 1Gi
-          requests:
-            cpu: 1
         volumeMounts:
         - mountPath: /etc/flyte/cluster-resource-templates
           name: cluster-resource-templates
@@ -1205,11 +1200,6 @@ spec:
         image: bitnami/postgresql:sandbox
         imagePullPolicy: Never
         name: wait-for-db
-        resources:
-          limits:
-            memory: 1Gi
-          requests:
-            cpu: 1
       serviceAccountName: flyte-sandbox
       volumes:
       - name: cluster-resource-templates
@@ -1253,7 +1243,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: 29be0ecfab0aea939a12ccb785931dedaccca4b6be7d3d38d925c4dc6487085e
+        checksum/secret: 2b44bc8183b23be063b704a6a4d7f9f461a0e654d1cb76da460863e0bbc8039e
       labels:
         app: docker-registry
         release: flyte-sandbox

diff --git a/docker/sandbox-bundled/manifests/dev.yaml b/docker/sandbox-bundled/manifests/dev.yaml
@@ -499,7 +499,7 @@ metadata:
 ---
 apiVersion: v1
 data:
-  haSharedSecret: dUtFcWNGbGpLSHFTSGJSMg==
+  haSharedSecret: amxUMEdxOEc4b1BxOXJaWA==
   proxyPassword: ""
   proxyUsername: ""
 kind: Secret
@@ -875,7 +875,7 @@ spec:
     metadata:
       annotations:
         checksum/config: 8f50e768255a87f078ba8b9879a0c174c3e045ffb46ac8723d2eedbe293c8d81
-        checksum/secret: f28d4e39d03147a771f800611c0bba800259f4596e6ea82b05b238df50f427c3
+        checksum/secret: b4b5f7919db1599f4f85df75e4d79b8953446ed40bbdc2b10d8997584e18f687
       labels:
         app: docker-registry
         release: flyte-sandbox