feat: Add support for browser authentication #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this is my first PR in this repo (or in any other repo from |
|
@dlouseiro thanks for contributing! Would you mind rebasing your branch to the latest |
Sure, will do! |
The purpose of this PR is to add a new authentication method, using SSO authentication using an external browser (documented [here](https://docs.snowflake.com/en/developer-guide/node-js/nodejs-driver-authenticate#using-single-sign-on-sso-through-a-web-browser)). While the most common setup for production-like executions on a remote machine is via user/password or RSA key-pair authentication, having browser based authentication is useful for local/dev executions using a Snowflake personal user (not a service account). ### Implementation: - Add new parameter to `meltano.yml` - Add new parameter to config dict in `target_snowflake/target.py` - Add new parameter to `README.md` - Add logic to handle browser based authentication in `target_snowflake/connector.py:get_sqlalchemy_url`
The purpose of this PR is to use the `secure-local-storage` extra in `snowflake-connector-python` for the SSO token caching to work. ### Implementation: - Add `secure-local-storage` extra to `pyproject.toml` - Update `poetry.lock`
DOne @edgarrmondragon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add support for SSO authentication via external browser (documented here).
As I detailed in this issue, while the most common authentication methods used for production users (Snowflake service account) are basic authentication (user/password) and RSA key-pair authentication, local executions can be done with personal users which, in some companies' Snowflake setup don't have a password, but can only authenticate via SSO (using an external browser).
Implementation details:
use_browser_authentication, which defaults tofalse(added toREADME.md,meltano.ymlandtarget_snowflake/target.py)secure-local-storageextra to thesnowflake-connector-python(needed for SSO tokens to be cacheable - documented here)poetry.locksettings_group_validationfor the three possible flows: user/password, user/private_key_path and user/use_browser_authenticationCloses #203