Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SSL #71

Closed
Tracked by #4
visch opened this issue Jan 16, 2023 · 1 comment · Fixed by #131
Closed
Tracked by #4

Support for SSL #71

visch opened this issue Jan 16, 2023 · 1 comment · Fixed by #131
Labels
Urgency/high

Comments

@visch
Copy link
Member

visch commented Jan 16, 2023 •
edited
Loading

This is technically already supported via the sqlalchemy_url configuration. But we should add config option(s) for SSL as well so you don't have to use sqlalchemy_url to support this.

Also as a part of this we should note in the sqlalchemy_url and dialect+driver that these settings are not safe to use as they can change significantly in the future, they should be used in combination with creating a ticket going over why you had to use the sqlalchemy_url and could not make the original configuration settings work.
@visch visch mentioned this issue Jan 16, 2023
Open
6 tasks
@aaronsteers
Copy link
Contributor

Related:

@aaronsteers aaronsteers mentioned this issue Jan 24, 2023
Open
@visch visch mentioned this issue Feb 1, 2023
Open
12 tasks
@tayloramurphy tayloramurphy mentioned this issue Mar 2, 2023
Closed
@tayloramurphy tayloramurphy mentioned this issue Apr 24, 2023
Closed
sebastianswms added a commit to sebastianswms/target-postgres that referenced this issue May 18, 2023
@sebastianswms
Adds support for ssl to address issue MeltanoLabs#71.
a8c96f4
@sebastianswms sebastianswms mentioned this issue May 18, 2023
Merged
visch added a commit that referenced this issue Jun 23, 2023
@sebastianswms @visch
feat: Adds support for SSL to address issue #71. (#131)
409e8e8 
Two types of SSL are supported:

- Checking the server's certificate against a certificate authority
using `ssl_enable`, for verifying the server's identity to the client.
- Passing a client certificate and private key to the server using
`ssl_client_certificate_enable`, for verifying the client's identity to
the server.

Each can be configured independently of the other. Using either or both
precludes the use of `sqlalchemy_url`.

Closes #71.

---------

Co-authored-by: Derek Visch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Urgency/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Adds support for SSL to address issue #71. sebastianswms/target-postgres
2 participants
@visch @aaronsteers