Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MetaData columns when schema is sent #21

Closed
visch opened this issue Oct 26, 2022 · 2 comments
Closed

Implement MetaData columns when schema is sent #21

visch opened this issue Oct 26, 2022 · 2 comments

Comments

@visch
Copy link
Member

visch commented Oct 26, 2022

https://github.com/BuzzCutNorman/target-mssql/blob/main/target_mssql/sinks.py#L104

I like this implementation a lot, I just think we should probably move the Table generation to happen only when a new schema is sent, and it should probably only happen when creating / updating a table not every batch.
@visch
Copy link
Member Author

visch commented Jan 16, 2023

Piece of #64

@visch visch mentioned this issue Jun 8, 2023
Merged
visch added a commit that referenced this issue Jun 15, 2023
@visch
feat: Use SQLAlchemy core objects where possible and append only added (
4f677d3 
#138)

Closes #121, #22, #64, #119, #21, #54
@visch
Copy link
Member Author

visch commented Jun 15, 2023

Close with #138

@visch visch closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@visch