Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace black, flake8, isort & pydocstyle with Ruff #47

Merged
merged 12 commits into from
Sep 23, 2024

Conversation

haleemur
Copy link
Contributor

Description

  • Replaces black, flake8, pydocstyle & isort with Ruff
  • Adds .pre-commit-config.yaml file
  • Fix some linting issues highlighted by Ruff in default setting, while disabling a 5 rules. The following rules are disabled:
    • ANN001
    • ANN401
    • S608
    • SLF001
    • EM101

ANN001 * ANN401 are disabled because the codebase has a few instances where params / return values don't specify type or return Any.

S608 flags string based queries. It will require a deeper refactor to leverage sqlalchemy exclusively.

SFL001 flags accesses to private members. This is done to patch _confirm_primitive_property.

EM101 flags strings passed to Exceptions, which I felt was safe to do.

closes: #43

tap_snowflake/client.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tap_snowflake/client.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
haleemur and others added 7 commits September 23, 2024 13:18
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
Co-authored-by: Edgar Ramírez Mondragón <[email protected]>
@haleemur
Copy link
Contributor Author

@edgarrmondragon addressed your comments.

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edgarrmondragon edgarrmondragon merged commit 38c8cc5 into MeltanoLabs:main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pre-commit and ruff as dev dependencies
2 participants