Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Work around unsupported json_serializer and json_deserializer #32

Merged
merged 2 commits into from
Aug 9, 2023
Merged

fix: Work around unsupported json_serializer and json_deserializer #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a35ccc
fix: Work around unsupported `json_serializer` and `json_deserializer`
edgarrmondragon Aug 8, 2023
e5af693
Add missing docstring
edgarrmondragon Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tap_snowflake/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,16 @@ def get_sqlalchemy_url(cls, config: dict) -> str:

return URL(**params)

def create_sqlalchemy_engine(self) -> sqlalchemy.engine.Engine:
"""Return a new SQLAlchemy engine using the provided config.

Developers can generally override just one of the following:
`sqlalchemy_engine`, sqlalchemy_url`.
def create_engine(self) -> sqlalchemy.engine.Engine:
"""Create SQLAlchemy engine instance.

Returns:
A newly created SQLAlchemy engine object.
A SQLAlchemy engine.
"""
return sqlalchemy.create_engine(
self.sqlalchemy_url, echo=False, pool_timeout=10
self.sqlalchemy_url,
echo=False,
pool_timeout=10,
)

# overridden to filter out the information_schema from catalog discovery
Expand Down