Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump singer-sdk to v0.31.0 #31

Closed
wants to merge 9 commits into from
10 changes: 5 additions & 5 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ packages = [
[tool.poetry.dependencies]
python = ">=3.7.1,<3.12"
requests = "^2.25.1"
singer-sdk = "~=0.30.0"
singer-sdk = "~=0.31.0"
snowflake-sqlalchemy = "^1.4.7"
snowflake-connector-python = "^3.0.2"
sqlalchemy = "<2"
Expand Down
4 changes: 4 additions & 0 deletions tap_snowflake/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ def create_engine(self) -> sqlalchemy.engine.Engine:
self.sqlalchemy_url,
echo=False,
pool_timeout=10,
# TODO: Enable these when `snowflake-sqlalchemy` supports it.
# https://github.com/snowflakedb/snowflake-sqlalchemy/issues/433
# json_serializer=self.serialize_json,
# json_deserializer=self.deserialize_json,
)

# overridden to filter out the information_schema from catalog discovery
Expand Down
Loading