Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: Add faker extra dependency to singer-sdk #496

Merged
merged 2 commits into from
Sep 5, 2024
Merged

packaging: Add faker extra dependency to singer-sdk #496

merged 2 commits into from
Sep 5, 2024

Conversation

maxmarcon
Copy link
Contributor

Fixes: #493

@maxmarcon maxmarcon mentioned this pull request Sep 4, 2024
Closed
@edgarrmondragon edgarrmondragon changed the title Add faker extra dependency to singer-sdk packaging: Add faker extra dependency to singer-sdk Sep 4, 2024
@edgarrmondragon
Copy link
Member

@maxmarcon I can't push to your main branch, can you run poetry lock and push the changes to poetry.lock? Thanks!

@edgarrmondragon edgarrmondragon self-requested a review September 4, 2024 22:45
@maxmarcon
Copy link
Contributor Author

@edgarrmondragon I did it and pushed the changes. Thanks

@edgarrmondragon edgarrmondragon merged commit 8cc55cd into MeltanoLabs:main Sep 5, 2024
7 checks passed
@edgarrmondragon
Copy link
Member

thanks @maxmarcon!

@maxmarcon
Copy link
Contributor Author

You're welcome @edgarrmondragon ! Thanks for creating a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

Assignees

@maxmarcon maxmarcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faker not available in stream api
2 participants
@maxmarcon @edgarrmondragon