chore: Pin requests to avoid issues with urllib3 2.0
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning version of requests to avoid urllib3 error witnessed in urllib 3.0 added in requests 2.30.0 version ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips 26 Jan 2017. See: urllib3/urllib3#2168
|
@eryanRM request your review please - Thank you! |
|
@pnadolny13 @guptaa3 I think bumping |
|
Thank you @edgarrmondragon but I think the tap should work irrespective of the singer-sdk version used, what do you think ? |
@guptaa3 Agreed 👍. Just commenting on how this will become a non-issue after the |
edgarrmondragon
approved these changes
May 17, 2023
edgarrmondragon
changed the title
requests to avoid issues with urllib3 2.0
kgpayne
approved these changes
May 18, 2023
|
@kgpayne @edgarrmondragon Thank you for approving the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning version of requests to avoid urllib3 error witnessed in urllib 3.0 added in requests 2.30.0 version
Error observed:
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips 26 Jan 2017. See: urllib3/urllib3#2168
Cause Identified:
https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
https://github.com/psf/requests/releases/tag/v2.30.0
https://github.com/psf/requests/blob/2ad18e0e10e7d7ecd5384c378f25ec8821a10a29/setup.py#L64