fix: state_type incorrect reference #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've been trying to implement this tap for some time now, as we want to use the
CDC
implementation with the defaultpgoutput
configuration. Using the postgres extractor definition here: https://hub.meltano.com/extractors/tap-postgres--airbyte/But I've faced an issue where the
state
was not being picked up for some reason.Eventually I figured it was missing the
metadata
definition to set thereplication-method
:But I've also noticed something else on the log:
After some inspection I saw these statements on the code and after changing them to what this PR proposal, it started working as expected.
I'm wondering if this was not an issue for someone at some point.