NVIPAMPool CRD #24
Merged
NVIPAMPool CRD #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollandf
force-pushed
the
pool-crd
branch
6 times, most recently
from
5efce78
to
1f21aef
Compare
rollandf
force-pushed
the
pool-crd
branch
2 times, most recently
from
4e6ec78
to
e7d8918
Compare
rollandf
force-pushed
the
pool-crd
branch
3 times, most recently
from
3964a63
to
caa0e7b
Compare
adrianchiris
reviewed
Sep 4, 2023
ykulazhenkov
reviewed
Sep 5, 2023
- Add CRD definition - Add Make targets - Add CR examples based on ConfigMap example Signed-off-by: Fred Rolland <[email protected]>
ykulazhenkov
reviewed
Sep 7, 2023
ykulazhenkov
reviewed
Sep 8, 2023
|
The controller part looks good for me. I added one extra comment about the node part. |
ykulazhenkov
approved these changes
Sep 11, 2023
| m.lock.Lock() | ||
| defer m.lock.Unlock() | ||
| m.reader = nil | ||
| return m.poolByName |
There was a problem hiding this comment.
locking/unlocking doesnt help us much here
should we create a copy of the map ? or just drop mutex ?
There was a problem hiding this comment.
locking/unlocking doesnt help us much here
should we create a copy of the map
Why? We use mutex here to protect shared internal map from concurrent writes
Add IPPool controller, watching Pools. The IP range allocations are available on the CR status. Node controller triggers event on all Pools when Node is added/updated/deleted. Signed-off-by: Fred Rolland <[email protected]>
Move from watching Nodes object and read IP range from annotation, to watch IPPools objects and get Allocations from their Status. Signed-off-by: Fred Rolland <[email protected]>
In case the IP configuration ConfigMap exists: - Create IPPools CR according to config spec - Read Nodes ranges annotation - Populate the IPpools Status allocations - Clear Nodes ranges annotation - Delete ConfigMap In case an issue is preventing the migration flow, it can be skipped by setting the env var 'MIGRATOR_DISABLE_MIGRATION'. Signed-off-by: Fred Rolland <[email protected]>
Signed-off-by: Fred Rolland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.