Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump multus version thin plugin #976

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: Bump multus version thin plugin #976

merged 2 commits into from
Sep 17, 2024

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Jun 24, 2024 •
edited
Loading

  • deploy multus thin plugin. update manifests accordingly

@adrianchiris adrianchiris changed the title Bump multus version thin plugin chore: Bump multus version thin plugin Jun 24, 2024
@adrianchiris adrianchiris changed the title chore: Bump multus version thin plugin [DNM] chore: Bump multus version thin plugin Jun 24, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9648016774

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 63.392%
Totals Coverage Status
Change from base Build 9579087671: 0.04%
Covered Lines: 3226
Relevant Lines: 5089
💛 - Coveralls

@adrianchiris adrianchiris force-pushed the bump-multus-version-thin branch from 64ba52f to 6507320 Compare June 27, 2024 14:09
@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9698154506

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 63.195%
Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 75.68%
controllers/macvlannetwork_controller.go 2 86.25%
pkg/state/state_skel.go 2 83.04%
api/v1alpha1/zz_generated.deepcopy.go 4 37.63%
controllers/hostdevicenetwork_controller.go 13 77.27%
Totals Coverage Status
Change from base Build 9687201354: -0.2%
Covered Lines: 3216
Relevant Lines: 5089
💛 - Coveralls

@adrianchiris adrianchiris force-pushed the bump-multus-version-thin branch from 6507320 to 5b7b7d9 Compare September 5, 2024 07:52
@coveralls
Copy link
Collaborator

coveralls commented Sep 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10810484241

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 60.528%
Totals Coverage Status
Change from base Build 10777107736: 0.2%
Covered Lines: 3323
Relevant Lines: 5490
💛 - Coveralls

@adrianchiris adrianchiris changed the title [DNM] chore: Bump multus version thin plugin chore: Bump multus version thin plugin Sep 5, 2024
@adrianchiris
Copy link
Collaborator Author

@e0ne @rollandf PTAL, id like to merge this one.

e0ne
e0ne previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. We need to mention in a release notes that Multus v4.1.0 is minimal supported starting 24.10 release

rollandf
rollandf reviewed Sep 11, 2024
View reviewed changes
manifests/state-multus-cni/0050-multus-ds.yml Outdated
{{- end }}
- key: cni-conf.json
path: 00-multus.conf
{{- end}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a space after the end ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lemme fix that. i should work both ways but for consisteny.

rollandf
rollandf previously approved these changes Sep 11, 2024
View reviewed changes
@adrianchiris
bump multus version
c0216fe 
- deploy multus thin plugin v4.1.0. update manifests accordingly

Signed-off-by: adrianc <[email protected]>
@adrianchiris
run make release-build
b76bed7 
Signed-off-by: adrianc <[email protected]>
@rollandf
Copy link
Member

Tested. We need to mention in a release notes that Multus v4.1.0 is minimal supported starting 24.10 release

@e0ne Please open an issue in docs repo so we remember on next version

@adrianchiris adrianchiris dismissed stale reviews from rollandf and e0ne via b76bed7 September 11, 2024 11:13
@adrianchiris adrianchiris force-pushed the bump-multus-version-thin branch from 5b7b7d9 to b76bed7 Compare September 11, 2024 11:13
@e0ne
Copy link
Collaborator

e0ne commented Sep 16, 2024

/retest-image_scan

@rollandf
Copy link
Member

image_scan CI failure is not related to this change.
I am OK with merging

@e0ne
Copy link
Collaborator

e0ne commented Sep 17, 2024

Tested. We need to mention in a release notes that Multus v4.1.0 is minimal supported starting 24.10 release

@e0ne Please open an issue in docs repo so we remember on next version

PR is created: Mellanox/network-operator-docs#106

@e0ne e0ne merged commit 42eccbc into Mellanox:master Sep 17, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rollandf rollandf rollandf approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianchiris @coveralls @rollandf @e0ne