Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use NVIDIA IPAM Plugin by default #970

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jun 11, 2024

No description provided.

ykulazhenkov
ykulazhenkov previously approved these changes Jun 11, 2024
@e0ne
Copy link
Collaborator Author

e0ne commented Jun 11, 2024

/retest-blackduck_scan

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462597584

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 63.844%

Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 2 79.5%
controllers/macvlannetwork_controller.go 2 86.25%
Totals Coverage Status
Change from base Build 9382713857: 0.06%
Covered Lines: 3249
Relevant Lines: 5089

💛 - Coveralls

rollandf
rollandf previously approved these changes Jun 11, 2024
example/crs/nvidia.com_v1alpha1_ nv_ipam_ippool_cr.yaml Outdated Show resolved Hide resolved
@e0ne e0ne dismissed stale reviews from rollandf and ykulazhenkov via efdbc19 June 11, 2024 10:33
@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9464003123

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.06%) to 63.844%

Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 2 79.5%
controllers/macvlannetwork_controller.go 2 86.25%
Totals Coverage Status
Change from base Build 9382713857: 0.06%
Covered Lines: 3249
Relevant Lines: 5089

💛 - Coveralls

@e0ne
Copy link
Collaborator Author

e0ne commented Jun 11, 2024

/retest-nic_operator_helm

@e0ne
Copy link
Collaborator Author

e0ne commented Jun 12, 2024

/retest-nic_operator_helm

4 similar comments
@maze88
Copy link
Collaborator

maze88 commented Jun 13, 2024

/retest-nic_operator_helm

@maze88
Copy link
Collaborator

maze88 commented Jun 13, 2024

/retest-nic_operator_helm

@maze88
Copy link
Collaborator

maze88 commented Jun 13, 2024

/retest-nic_operator_helm

@maze88
Copy link
Collaborator

maze88 commented Jun 13, 2024

/retest-nic_operator_helm

@adrianchiris adrianchiris merged commit 2973e58 into Mellanox:master Jun 17, 2024
16 checks passed
@@ -6,7 +6,7 @@ metadata:
k8s.v1.cni.cncf.io/networks: rdma-net-ipam

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e0ne seems like a tyope and change should be on this line

@noama-nv
Copy link

@e0ne if we default nv-ipam for vanilla kubernetes i think we should enable it by default in openshift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants