Project name input is not being sanitized #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melkeydev
requested changes
Nov 14, 2023
cmd/ui/textinput/textinput.go
Outdated
| // InitialTextInputModel initializes a textinput step | ||
| // with the given data | ||
| func InitialTextInputModel(output *Output, header string, program *program.Project) model { | ||
| ti := textinput.New() | ||
| ti.Focus() | ||
| ti.CharLimit = 156 | ||
| ti.Width = 20 | ||
| ti.Validate = sanitizeInput |
cmd/ui/textinput/textinput_test.go
Outdated
|
|
||
| import "testing" | ||
|
|
||
|
|
|
|
||
|
|
||
|
|
||
| func TestInputSanitization(t *testing.T) { |
There was a problem hiding this comment.
this is really cool - first test LUl
Ujstor
added a commit
to Ujstor/go-blueprint
that referenced
this pull request
Nov 14, 2023
* Gives an error if a directory already exists. Colorized the errors when creating a new project if occurred (Melkeydev#72) Co-authored-by: Omar <[email protected]> * fix 🐛: added hotfix to taps on homebrew (Melkeydev#87) * fix 🐛: completion in homebrew (Melkeydev#100) * fix 🐛: completion in homebrew * fix 🐛: added comment about the use of the GoBlueprintVersion variable * feat ✨: added missing completion install in goreleaser config * fix 🐛: misstyped completion file name * fix 🐛: permissions on completion script * fix 🐛: missing archived complition folder needed for completion in brew * fix 🐛: fixed ldfs flag * docs 📚(README.md): fixed the brew installation command * Project name input is not being sanitized (Melkeydev#103) * fix: No project name input sanitization * feat: Starting continuous integration * fix: nits --------- Co-authored-by: Omar <[email protected]> Co-authored-by: Omar <[email protected]> Co-authored-by: Zine Moualhi <[email protected]> Co-authored-by: Camilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem/Feature
I can pass two or more spaces as a project name causing it to fail. In the same way I can pass special characters that can mess with the integrity of the target file tree.
Description of Changes:
Checklist