Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] make tailwind should be called tailwind-install instead #326

Closed
LarsArtmann opened this issue Nov 12, 2024 · 4 comments
Closed

[Bug] make tailwind should be called tailwind-install instead #326

LarsArtmann opened this issue Nov 12, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@LarsArtmann
Copy link
Contributor

What is the problem?

make tailwind feels like it is there to create an output.css file.
But it only installs tailwind if you do not already have it.
As with make templ-install, we should be consistent with the naming.

Operating System

ALL

Architecture Version (x86, x64, arm, etc)

ALL

Steps to reproduce

run make tailwind

Relevant log output

None
@Ujstor
Copy link
Collaborator

Ujstor commented Nov 16, 2024

We can change the target naming to be consistent with the operation it performs.

@Ujstor Ujstor added the good first issue Good for newcomers label Nov 20, 2024
@pradytpk
Copy link
Contributor

pradytpk commented Nov 21, 2024

I would to Like to work on this issue.
Can you please assign me.
@Ujstor @LarsArtmann

pradytpk added a commit to pradytpk/go-blueprint that referenced this issue Nov 21, 2024
pradytpk added a commit to pradytpk/go-blueprint that referenced this issue Nov 21, 2024
pradytpk added a commit to pradytpk/go-blueprint that referenced this issue Nov 21, 2024
@Ujstor Ujstor assigned Ujstor and unassigned Ujstor Nov 21, 2024
@Ujstor
Copy link
Collaborator

Ujstor commented Nov 21, 2024

This is yours. I will check the PR

@Ujstor
Copy link
Collaborator

Ujstor commented Nov 24, 2024

Merged, tnx.

@Ujstor Ujstor closed this as completed Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants