BUGFIX: Task tracking #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
linked to #254 |
justnat3
force-pushed
the
task-track-patch
branch
from
00a69c6
to
459db7d
Compare
royanger
suggested changes
Mar 30, 2023
While I was fixing a ts-ignore, I found that track logic didn't really act the way it should even still. So now toggleInProgressState is used by flag and not by hoping the task is in the right state when we toggle.
|
please test this to see if you find the behavior is still not what we want it to be. I guess I didn't get it reproduce when I originally submitted the PR. So we just pass inProgress by flag now, seems like the way to go. Matches some of the other state management that this point anyways. Cheers, -Nate |
mechakin
pushed a commit
to mechakin/astrostation
that referenced
this pull request
Oct 16, 2023
BUGFIX: Task tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By tracking a task, you could no longer not track it without resorting to a double-click.
Untrack is now in place for a task that is already being tracked.