-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video: Update to VidstackPlayer library #5609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I can't tell if changing the quality does anything
- Changing captions or speed does not seem to have any effect, I don't see any subtitles
- Sometimes when clicking changing video, nothing happens, page seems broken.
This should not be changed, hence the DefaultQuality parameter name. I removed the change button.
Yeah, this seems to not work with Plyr layout while it works with default layout. I might report the issue on their repo.
For me it works. Cannot reproduce. |
The menu should work now. |
DEMO:
DOCS: |
Documentation/Blazorise.Docs/Pages/News/2024-07-15-release-notes-160.razor
Outdated
Show resolved
Hide resolved
Documentation/Blazorise.Docs/Pages/News/2024-07-15-release-notes-160.razor
Outdated
Show resolved
Hide resolved
I have fixed the problems you mentioned. Some other things were already behaving as before, so I will skip them to avoid postponing the release. Proceeding with the merge 🤞 |
Closes #4914
Closes #5479
Updated Video to use VidstackPlayer library. The Plyr library was archived in favor of the new library sampotts/plyr#2737
In this version, I have made it work as closely as before, and from my tests, it should not have any breaking changes.