Documentation #12
Merged
Documentation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning the work of getting the code base ready to upload to pypi.
Also starting to clean up how the report methods are called. Don't like how the documentation looks when passing a configuration dictionary in as the only parameter, instead will pass in **configuration
Now need to process all of the todos and make sure that the changes to the arguments work with the reports that I have already defined.
- account walker can now take a category definition - remove **kwargs from reports for testing purposes - more documentation for bucket and bucket generation - remove category_budget_level report (can now use budget_level) - documentation for reports base module - fix arguments for multi_report to match the rest of the reports
Remove todo associated with start and end (already fixed). Use credit_account.sign instead of magic multipliers.
- account_levels, replace good_value with goal - use account.sign instead of magic - sign.
- replace expenses_base with expenses (arguments) - use current date configuration value instead of date.today()
Need this to be consistent across the board and it's not. So this code is starting to fix that work.
want them to be a list of arrays, instead of a list of dictionaries.
- change account parameter names to remove smurfing - use account walker parameters for income and retirement account params
- Return a list of accounts associated with a category, not a set
- wrapper now provides a name for the group by default
- Remove todos in the networth calculators
- account walker parameters in the payload calculator
- no longer have to differentiate between liability and regular
accounts in the payload calculator.
- Updated documentation to explain away some of the TODOs - Remove need for category mapping in investment allocation report - Update split query to handle credits and debits, and to sort based on transaction.post_date (this my improve performance now because not using sub queries).
- setup.py url - Remove "empty" __init__.py contents - Fix name in license - Update values in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.