This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Replace ncp, mkdirp, and rimraf with fs-extra for io.js support #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -351,7 +348,7 @@ function copyIntoPlace(extractedPath, targetPath) { | |||
| .then(function () { | |||
| // Cleanup extracted directory after it's been copied | |||
| console.log('Removing', extractedPath) | |||
| return kew.nfcall(rimraf, extractedPath).fail(function (e) { | |||
| return kew.nfcall(fs.remove, extractedPath).fail(function (e) { | |||
There was a problem hiding this comment.
i think this is now obsolete? fp.move is equivalent to ncp + rimraf
|
thanks, can you do a quick cla? |
|
Will do |
|
Signed and removed the unnecessary fs.remove code |
|
lgtm! |
nicks
added a commit
that referenced
this pull request
Jan 27, 2015
Replace ncp, mkdirp, and rimraf with fs-extra for io.js support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #275 by replacing ncp, mkdirp, and rimraf with fs-extra. Have tested iojs 1.0.4 on OS X. I will add iojs testing to the travis.yml as soon as travis supports it per travis-ci/travis-ci#3108