Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikis on the same domain with not-Fandom-like different paths don't get saved correctly #67

Closed
AttemptToCallNil opened this issue May 18, 2021 · 2 comments

Comments

@AttemptToCallNil
Copy link
Contributor

Try saving a "wiki farm" with these wikis:

https://cat.cat/Main Page
https://cat.cat/de/Main Page
https://cat.cat/ru/Main Page

The current "get-wikiname-from-url" algorithm assumes that wiki farms either use separate subdomains, or Fandom-like paths that start with /[two letters]/wiki. In other cases (same domain, other kind of paths), the login form will only save the last entry and overwrite the rest with it.

I don't think there can be a universal conflict resolution algorithm for this problem, so I guess adding indices like cat.cat [2], cat.cat [3] is the way to go, at least for now.

@Helcostr
Copy link
Member

Helcostr commented Jun 6, 2021

Uh oh XD

I think instead of object based keys... it should be array based. That way overwriting won't happen.

IIRC, I had an array based system last time 🤔 .

@AttemptToCallNil
Copy link
Contributor Author

I already fixed this issue in my coming PR.

AttemptToCallNil added a commit to AttemptToCallNil/MAGE that referenced this issue Jun 14, 2021
@pcjcos pcjcos closed this as completed in 95a2fdb Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants