Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message title for Google Cloud Messge (GCM) #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnroyer
Copy link

iOS app does not support message title, but Android can.

I add message title in GooglePushService.php and change work flow in method send() to set title for Android message.

I've test on Sony mobile. May need some help testing on other devices.
Thanks

ZeroHuang added 2 commits April 29, 2016 17:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nickygerritsen
Copy link
Contributor

First of all, thanks!

I think it makes sense to have the AbstractPushService expose the setMessageTitle function and have the Apple Push Service throw an exception or even ignore the value completely.

So that you do not have to do that much runtime checking of the types.

@renefloor
Copy link

renefloor commented May 3, 2016

The library now supports 'title' and 'content' in stead of 'message'. There is not really a reason in Android to support only 2 types of data. It would be better to make this more flexibel so that users of the library can choose what to send and add for example an image url.

@johnroyer
Copy link
Author

@nickygerritsen: I add definition in AbstractPushService.php and PushService.php. And throw RuntimeException when method called in ApplePushService.

Can you review this change for me? Thanks.

@johnroyer
Copy link
Author

@renefloor: I know that GCM and APNS now support custom data / field. It is a lot of works to do before we support custom data into Push service. How about open a issue to figure out a better way ?

@renefloor
Copy link

@johnroyer I opened an issue so it won't be lost over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants