-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video loading on linux #217
Comments
One possibility is that AdvantageScope could detect when the temp folder is full and switch to writing somewhere on the main filesystem. That's not ideal because the OS might start writing files to disk or include the images in automatic backups, but it's probably a good option as a fallback. |
YouTube video urls would still be a remaining issue, I have checked the console and network tab for when I click the paste button and no network requests start, and no console messages log |
TBA got updated with match videos, so now after testing, the same problem exists for TBA video loading as well. |
You won't see any network requests or console messages when downloading videos because all of that processing is handled by the main process, not the renderers. However, YouTube and TBA downloads are likely to encounter the same filesystem issue. |
I'm attempting to recreate this by writing the video cache to a filesystem with limited free space, but ffmpeg appears to produce an error that is propagated properly to the rendered when no more space is available. Can you send the console output from the main process when loading a local video? You'll need to run AdvantageScope from the command line to see that output. |
There appears to be two problems here, the filesystem issue, and an issue preventing online videos to load, and infinite loading with no visible progress. I will run both through the terminal, and send the results. |
There appears to be two problems here, the filesystem issue, and an issue preventing online videos to load, and infinite loading with no visible progress. I will run both through the terminal, and send the results. With a local video:
When clicking the TBA button or YT button: |
This behavior is odd to me, because the video loaded is under 200 megabytes large, and it somehow fills up my entire temporary folder which is configured to have 6 gigabytes of space. |
It looks like the error with the local file matches what I'm seeing, so I'll look at how I can work around that. It's expected that AdvantageScope will produce files much larger than the original video. It needs to decode the full video ahead of time to enable efficient scrubbing, since the type of back-and-forth video scrubbing required by AdvantageScope works very poorly when decoding videos in real time (most video formats are designed only for playback in one direction). I'm not sure about the YouTube issue, since that match video downloads correctly for me. Have you tried running it with different videos, computers, or networks? It would be helpful to try to narrow down the conditions for recreating this. |
I have tried running the TBA and Youtube loading with multiple different videos on this machine, and none have worked. However running on a windows software laptop from my team, it works as expected. I haven't tried other machines running Linux however, but on my desktop it does not work. I can try running on a different Linux machine but I would have to borrow some kind of device. Has anyone attempted to recreate this on a linux system? |
Videos from YouTube and TBA are loading correctly for me on Ubuntu 22.04 with AdvantageScope 4.0.0-beta-1. I've had issues in the past related to DNS resolution, but that always prints an error from ffmpeg (like you were seeing from a local video). What distribution and version of Linux are you running? |
I am running Arch Linux with a rolling release with Kernel version 6.10.7 |
I have a seperate windows hard drive, so tonight I will test on the same machine with the windows operating system to see if it is machine specific or operating system specific. |
Update, I have run this on windows on the same pc, and instead of it doing nothing, I get a 403 error straight away.
Im not sure what would cause this to happen though, and this error didnt show up on the linux OS, it just did nothing. (sorry for the no wrapping, windows powershell doesnt copy-paste line breaks for me) |
I added logic to switch to a fallback directory on the main drive if the temporary volume is out of space, which should address the issue with local files. My best guess is that the YouTube/TBA problems are related to some type of issue with the YouTube download API, which of course isn't officially supported by Google. There could be any number of underlying reasons, whether it's related to user agent, IP address, etc. It seems like it's still working in many cases, but ultimately YouTube is very unpredictable and I know they use tactics like checking the IP address to prevent some types of misuse. We will continue to update the relevant dependency (ytdl-core) as new versions are available, but otherwise I think this issue falls under the warning in the docs that "YouTube and TBA video download may failed unexpectedly due to changes on YouTube's servers." |
On both the 4.0.0 beta and 3.2.1, when clicking the youtube loading button, it just loads infinitely. Loading a local file works however, but near the end of video loading, it errors loading the video, after checking my filesystem, the seeming issue seems to be that my temporary folder is getting extremely full from just a single video, and then erroring while trying to write the video to the filesystem where it is impossible to write to.
The text was updated successfully, but these errors were encountered: